iOS: Hide Alerts due to navigation issue #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ksharma-xyz
changed the title
ksharma-xyz
changed the title
ksharma-xyz
changed the base branch from
12-04-add_isdebug_method_to_appplatform
to
graphite-base/423
ksharma-xyz
force-pushed
the
graphite-base/423
branch
from
653b610 to
9f04ee0
Compare
ksharma-xyz
force-pushed
the
12-04-alerts_fix_ios
branch
from
4a2c533 to
99cc0f1
Compare
ksharma-xyz
force-pushed
the
12-04-alerts_fix_ios
branch
from
99cc0f1 to
80fd501
Compare
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Removed service alert priority and restricted alert display to Android platform only.
What changed?
LocalPlatformTypeProvidertoLocalAppPlatformProviderfor claritypriorityfield fromServiceAlertdata classHow to test?
Why make this change?
The service alert priority was unused and added unnecessary complexity. Additionally, iOS devices were crashing when navigating with HTML content as string arguments (see JetBrains issue CMP-7180). This change provides a temporary solution by limiting alerts to Android while maintaining app stability on iOS.